Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fenecon] Initial contribution #17174

Merged
merged 36 commits into from
Sep 8, 2024
Merged

[fenecon] Initial contribution #17174

merged 36 commits into from
Sep 8, 2024

Conversation

nixoso
Copy link
Contributor

@nixoso nixoso commented Jul 28, 2024

@nixoso
Initial implementation of the FENECON Binding
9d2c67c 
- Binding for FENECON via REST-API access implemented
- Documentation for FENECON added
- The implementation Closes openhab#17173

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso nixoso requested a review from a team as a code owner July 28, 2024 19:50
nixoso added 7 commits July 28, 2024 22:00
@nixoso
Fix: Enter new binding in bundle pom.xml
32194f6 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Fix: Enter new binding in bom/openhab-addons pom.xml
83f63a1 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Fix format validation in bundle pom.xml
6e2f943 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Fix warning in markdown
3b338e1 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Fix null pointer warnings
a4e7d5a 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Fix tow checkstyle notices.
0cf1589 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Removed unnecessary code comments.
02ff037 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Jul 28, 2024
@lsiepel lsiepel changed the title [fenecon] Initial implementation of the FENECON Binding [fenecon] Initial contribution Jul 29, 2024
lsiepel
lsiepel requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. Don't forget to add yourself to the codeowner file. After all comments have been addressed i have to do another review round.
Please also check compilation and SAT warnings (not looked at that right now)

bundles/org.openhab.binding.fenecon/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/README.md Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/pom.xml Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
nixoso added 14 commits August 2, 2024 23:08
@nixoso
Add code owner information.
469c7ef 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Change initial delay of the polling job.
6281b0d 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Change log level of initialization message.
496594f 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Add unitHint for battery state
816c395 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Fix naming convention
113dcef 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Change emergency-power-mode description
6518705 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Label / Naming improvements
6ac4c93 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Add default translation file
d013bf4 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Change thing type id
f716017 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Remove comment
fc1e6e5 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Seperation of concerns and extract strings as constants
40a3199 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Small refactorings for converting values.
1f472f8 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Added tests.
10455d7 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Add connection tag to addon.xml
89fb2ab 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@lsiepel
Copy link
Contributor

lsiepel commented Aug 3, 2024

There is a conflict to fix. I’ll come back to this. Two weeks AFK.

nixoso added 3 commits August 3, 2024 22:05
@nixoso
[Review]: Add tabs for DSL demo.rules
6308e04 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Change thing type id to home-device
6e13a9e 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Remove a checkstyle and PMD info and warning.
6f101bf 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
nixoso added 4 commits August 15, 2024 23:04
@nixoso
Error handling improved.
1dd5e07 
If Fenecon delivers partially faulty data because parts of the system
are offline, an attempt is made to read out as much data as possible.

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Handling improved for values that are not available.
1a567a4 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Added new channels for each consumption-active-power-phase 1, 2 and 3.
de82640 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Added new channels for consumption and production max active power.
c7af0d9 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Copy link
Contributor Author

nixoso commented Aug 18, 2024

@lsiepel can you please take a look at the "PR-openHAB addons" because of the errors (de82640, c7af0d9) in the build, unfortunately I can't find out anything about it and wouldn't see it in relation to my changes.

@lsiepel
Copy link
Contributor

lsiepel commented Aug 18, 2024

Well there is a conflict and the bundles/pom.xml is showing many ampty lines, maybe you want to revert that file and add your binding again. I will try look at the other changes somewhere this week.

nixoso added 2 commits August 24, 2024 14:04
@nixoso
Fix format conflict.
a66b870 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Fix format conflict.
4c081d1 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Copy link
Contributor Author

nixoso commented Aug 24, 2024

@lsiepel
I could finally solve the problem with the formatting. But now there are still problems with the “PR-openHAB-Addons” but the error does not seem to be caused by the change. Do you have another tip?

@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 24, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Aug 24, 2024

@lsiepel I could finally solve the problem with the formatting. But now there are still problems with the “PR-openHAB-Addons” but the error does not seem to be caused by the change. Do you have another tip?

Ignore that for now. Jenkins is somewhat unstable

lsiepel
lsiepel requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup suggestions and a question. I think we are almost there.

bundles/org.openhab.binding.fenecon/pom.xml Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.fenecon/README.md Outdated Show resolved Hide resolved
...inding.fenecon/src/main/java/org/openhab/binding/fenecon/internal/api/FeneconController.java Outdated Show resolved Hide resolved
nixoso added 3 commits August 29, 2024 21:00
@nixoso
[Review]: Removed unnecessary tags.
77b4893 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Removed unnecessary comment.
8f72843 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[Review]: Removed unnecessary blank lines.
354c41e 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
lsiepel
lsiepel requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two existing comments are left.

bundles/org.openhab.binding.fenecon/pom.xml Show resolved Hide resolved
@nixoso
[Review]: Change from java to jetty common httpclient.
9bd8908 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 8, 2024
lsiepel
lsiepel approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

@lsiepel lsiepel merged commit 6b2462c into openhab:main Sep 8, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 8, 2024
nixoso added a commit to nixoso/openhab-docs that referenced this pull request Sep 14, 2024
@nixoso
Add logo for fenecon binding
0e30ad1 
see openhab/openhab-addons#17174 and
openhab/openhab-addons#17173

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso nixoso mentioned this pull request Sep 14, 2024
Merged
stefan-hoehn pushed a commit to openhab/openhab-docs that referenced this pull request Sep 18, 2024
@nixoso
Add logo for fenecon binding (#2366)
953cee4 
see openhab/openhab-addons#17174 and
openhab/openhab-addons#17173

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
@nixoso @digitaldan
[fenecon] Initial contribution (openhab#17174)
07bca65 
* Initial implementation of the FENECON Binding

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@nixoso @pgfeller
[fenecon] Initial contribution (openhab#17174)
96955a3 
* Initial implementation of the FENECON Binding

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@nixoso @joni1993
[fenecon] Initial contribution (openhab#17174)
62b3906 
* Initial implementation of the FENECON Binding

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@nixoso @matchews
[fenecon] Initial contribution (openhab#17174)
4cb7613 
* Initial implementation of the FENECON Binding

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[fenecon] New binding for FENECON
3 participants
@nixoso @lsiepel @jlaur